RFR: 8357445: G1: Time-Based Heap Uncommit During Idle Periods [v2]

Monica Beckwith mbeckwit at openjdk.org
Wed Jul 16 22:11:52 UTC 2025


On Wed, 16 Jul 2025 18:40:14 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Monica Beckwith has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Normalize encoding and line endings for G1 GC time-based tests
>
> src/hotspot/share/runtime/vmOperations.cpp line 649:
> 
>> 647: }
>> 648: #endif // INCLUDE_G1GC
>> 649: 
> 
> Please move to `g1VMOperations.cpp`

Good suggestion! Moved `VM_G1ShrinkHeap::doit()` implementation from `vmOperations.cpp` to `g1VMOperations.cpp` where it belongs with the other G1-specific VM operations. Much better organization.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26240#discussion_r2211705285


More information about the hotspot-gc-dev mailing list