RFR: 8357445: G1: Time-Based Heap Uncommit During Idle Periods [v2]

Monica Beckwith mbeckwit at openjdk.org
Thu Jul 17 01:40:49 UTC 2025


On Wed, 16 Jul 2025 21:25:05 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> IIUC `retire` a region means that the region has been retired from allocation, however, the particular region is in active use just that we can no longer allocate out of this region. Eventually, this region will be evacuated and `hr_clear()` called. So `record_activity()` during retirement is redundant.
>
> `hr_clear` is called when the region is freed in `G1CollectedHeap::free_region`

You're right about removing the redundant calls. Plus, my logic already ensures only empty regions are considered for uncommitting, so retired region timestamps wouldn't affect decisions anyway

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26240#discussion_r2211954818


More information about the hotspot-gc-dev mailing list