RFR: 8357445: G1: Time-Based Heap Uncommit During Idle Periods [v2]
Monica Beckwith
mbeckwit at openjdk.org
Thu Jul 17 01:43:48 UTC 2025
On Wed, 16 Jul 2025 21:09:46 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>>> For existing Heap Resizing tasks, we use the tags `(gc, ergo, heap)`, I would suggest we maintain that.
>>
>> I'd like to discuss the logging tag choice. While I understand the consistency argument for using (gc,ergo,heap), I believe (gc,sizing) is more appropriate here because:
>>
>> 1. This is a distinct sizing mechanism, not traditional ergonomic heap management
>> 2. Users troubleshooting time-based sizing specifically will benefit from a dedicated tag
>> 3. It aligns with the feature name and purpose
>> 4. It provides better separation of concerns for logging
>>
>> Would you be open to keeping (gc,sizing) for semantic clarity?
>
> My argument is related to consistency, if there are reasons to have this logging distinct from the `(gc, ergo, heap)`, that is fine by me.
Thank you for being open to the distinct logging tags. I'll keep (gc,sizing) to maintain the semantic clarity for time-based heap sizing troubleshooting. This will help users and support teams isolate time-based sizing behavior from traditional ergonomic heap management.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26240#discussion_r2211958648
More information about the hotspot-gc-dev
mailing list