RFR: 8357445: G1: Time-Based Heap Uncommit During Idle Periods [v4]

[Monica Beckwith]

On Thu, 17 Jul 2025 07:08:57 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Monica Beckwith has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8357445: Remove redundant record_activity calls and leftover initialize call
>>   
>>   - Remove record_activity() from retirement methods as hr_clear() is always last
>>   - Remove leftover initialize() call since initialization moved to constructor
>>   - Remove unused G1 includes from vmOperations after moving VM_G1ShrinkHeap
>
> src/hotspot/share/gc/g1/g1HeapSizingPolicy.cpp line 544:
> 
>> 542:     size_t max_shrink_bytes = current_heap > min_heap ? current_heap - min_heap : 0;
>> 543: 
>> 544:     log_trace(gc, sizing)("Time-based evaluation details: current_heap=%zuB min_heap=%zuB "
> 
> I do not think `trace`log messages need the "details" in `Time-based evaluation details" - this is already indicated by the log level.
> 
> Also, in contrast to other "Time-based evaluation" messages this has a ":" at the end, which is inconsistent.

ok changed to:
log_trace(gc, sizing)("Uncommit evaluation: current_heap=%zuB min_heap=%zuB ...")

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26240#discussion_r2216604414