RFR: 8350621: Code cache stops scheduling GC [v5]

Thomas Schatzl tschatzl at openjdk.org
Tue Jul 22 07:15:25 UTC 2025


On Mon, 21 Jul 2025 19:57:48 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   * kbarrett review, remove unsupported gc causes for that branch
>
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 1892:
> 
>> 1890:       assert(cause == GCCause::_g1_humongous_allocation ||
>> 1891:              cause == GCCause::_g1_periodic_collection ||
>> 1892:              cause == GCCause::_wb_breakpoint, "Unsupported cause %s", GCCause::to_string(cause));
> 
> `_wb_breakpoint` is unexpected here too, since it's completely handled by an earlier clause in the if-ladder.
> The first two are the entire residue that should be able to get here.

fixed. Thanks for pointing this out.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26189#discussion_r2221452773


More information about the hotspot-gc-dev mailing list