RFR: 8363929: G1: Add G1 prefix to various G1 specific global locks

Aleksey Shipilev shade at openjdk.org
Thu Jul 24 08:35:55 UTC 2025


On Wed, 23 Jul 2025 14:02:49 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this renaming of a few G1 specific locks to have a G1 prefix to make it clear that they should not be used elsewhere.
> 
> Testing: local compilation, gha
> 
> Thanks,
>   Thomas

Looks reasonable, just needs a few more cosmetics.

src/hotspot/share/runtime/mutexLocker.hpp line 73:

> 71: extern Mutex*   NonJavaThreadsList_lock;         // a lock on the NonJavaThreads list
> 72: extern Mutex*   NonJavaThreadsListSync_lock;     // a lock for NonJavaThreads list synchronization
> 73: extern Monitor* G1CGC_lock;                        // used for coordination between

In all hunks in this file: comment indenting. May even add "G1" to comments, where appropriate.

-------------

PR Review: https://git.openjdk.org/jdk/pull/26444#pullrequestreview-3050656256
PR Review Comment: https://git.openjdk.org/jdk/pull/26444#discussion_r2227836256


More information about the hotspot-gc-dev mailing list