RFR: 8361055: Serial: Inline SerialHeap::process_roots [v5]
Kim Barrett
kbarrett at openjdk.org
Fri Jul 25 22:08:56 UTC 2025
On Fri, 18 Jul 2025 13:14:38 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Refactor roots processing in Serial (young-gc and full-gc) to clean up the control-flow and make is clearer what roots and closures are used in each context.
>>
>> Test: tier1-8
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>
> - review
> - Merge branch 'master' into sgc-roots
> - review
> - Merge branch 'master' into sgc-roots
> - review
> - Merge branch 'master' into sgc-roots
> - review
> - sgc-roots
I'm still not entirely convinced that spreading things out is an improvement.
I think I would have preferred improvements to the centralized approach.
But this is better than what we currently have.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26038#pullrequestreview-3056891044
More information about the hotspot-gc-dev
mailing list