RFR: 8364166: Parallel: Remove the use of soft_ref_policy in Full GC [v2]
Thomas Schatzl
tschatzl at openjdk.org
Tue Jul 29 08:34:55 UTC 2025
On Tue, 29 Jul 2025 08:20:35 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Simple removing redundant soft-ref-clearing checking in full-gc, because Parallel already reacts to this particular gc-cause, `_wb_full_gc`.
>>
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - review
> - Merge branch 'master' into pgc-soft-ref
> - pgc-soft-ref
Marked as reviewed by tschatzl (Reviewer).
src/hotspot/share/gc/parallel/psParallelCompact.hpp line 765:
> 763:
> 764: static bool invoke(bool clear_all_soft_refs);
> 765: static bool invoke_no_policy(bool clear_all_soft_refs);
I would prefer to keep using `maximum_heap_compaction` as `clear_all_soft_refs` seems too specific. However I am not insisting on this.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26496#pullrequestreview-3066225226
PR Review Comment: https://git.openjdk.org/jdk/pull/26496#discussion_r2238977946
More information about the hotspot-gc-dev
mailing list