RFR: 8358586: ZGC: Combine ZAllocator and ZObjectAllocator [v12]

Axel Boldt-Christmas aboldtch at openjdk.org
Tue Jul 29 08:56:02 UTC 2025


On Mon, 28 Jul 2025 12:33:52 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:

>> Hello,
>> 
>> After [JDK-8353184](https://bugs.openjdk.org/browse/JDK-8353184), ZAllocator has essentially become a mirror of ZObjectAllocator, questioning the relevance of ZAllocator. The purpose of this RFE is to combine ZAllocator and ZObjectAllocator into a single class ZObjectAllocator.
>> 
>> The solution I propose moves the new ZObjectAllocator as a data member in ZHeap, and is accessed solely from ZHeap. ZObjectAllocator stores a number of allocators, one for each age. Instead of storing eden and relocation allocators separately, all allocators are now in a single array, which makes it more straightforward to iterate over all allocators (when retiring pages for example). Since the underlying allocator (called PerAge) needs to be constructed with different ages, we can't use the default constructor/initialization, so I have a solution in-place for dealing with this.
>> 
>> Undoing an object allocation has been moved in its entirety (not calling into ZObjectAllocator) to ZHeap, where it fits much better.
>> 
>> Testing:
>> * Oracle's tier 1-5
>
> Joel Sikström has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8358586_zallocator_cleanup
>  - Make NONCOPYABLE(ZDeferredConstructed) private
>  - Add template spacing and remove extra semicolon
>  - Copyright year
>  - Move definition of ZDeferredConstructed to inline header
>  - Merge branch 'master' into JDK-8358586_zallocator_cleanup
>  - Rework ZObjectAllocator
>  - Private member variables in ZObjectAlloactorImpl
>  - Move implementation to .cpp and static-only interface in .hpp
>  - Consistent template friend style
>  - ... and 5 more: https://git.openjdk.org/jdk/compare/19f94881...1552e399

Marked as reviewed by aboldtch (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25693#pullrequestreview-3066331409


More information about the hotspot-gc-dev mailing list