RFR: 8361897: gc/z/TestUncommit.java fails with Uncommitted too slow
Joel Sikström
jsikstro at openjdk.org
Wed Jul 30 11:28:53 UTC 2025
On Tue, 29 Jul 2025 14:58:09 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> This proposed change loosens the the threshold for flagging slow un-committing as an error in TestUncommit.java. Rather than requiring the un-committing be completed within 3 ZUncommitDelay, allow up to 5 ZUncommitDelay to accommodate the test being executed in environments where external factors affect whether un-committing is run as expected.
>
> In the observed intermittent failures, what can be seen is that the un-committer thread wakes up a significant time after the expected timeout has expired. And because we expect multiple timeouts, the accumulated extra time waiting can push the actual delay just past 3 ZUncommitDelay. Using a factor of 5 instead should remove all but the most extreme intermittent occurrences and still capture if the un-commit logic breaks completely.
Looks good.
-------------
Marked as reviewed by jsikstro (Committer).
PR Review: https://git.openjdk.org/jdk/pull/26536#pullrequestreview-3070976280
More information about the hotspot-gc-dev
mailing list