RFR: 8364423: G1: Refactor G1UpdateRegionLivenessAndSelectForRebuildTask

[Albert Mingkun Yang]

On Thu, 31 Jul 2025 12:07:13 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this refactoring of `G1UpdateRegionLivenessAndSelectForRebuildTask` to remove some code duplication, which makes it simpler to add more common code
> 
> Testing: gha
> 
> Thanks,
>   Thomas

A minor subjective suggestion, but up to you.

src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 1262:

> 1260:       }
> 1261:       _cm->update_top_at_rebuild_start(hr);
> 1262:     }

I feel this logic is too caller-specific -- reading its name `update_live_region` doesn't reveal much what this method should do/deliver.

-------------

Marked as reviewed by ayang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26574#pullrequestreview-3075725547
PR Review Comment: https://git.openjdk.org/jdk/pull/26574#discussion_r2245596038