RFR: 8334759: gc/g1/TestMixedGCLiveThreshold.java fails on Windows with JTREG_TEST_THREAD_FACTORY=Virtual due to extra memory allocation
Thomas Schatzl
tschatzl at openjdk.org
Mon Jun 2 08:02:02 UTC 2025
On Mon, 2 Jun 2025 07:06:16 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Hi all,
>>
>> please review this change that "fixes" the `TestMixedGCLiveThreshold.java` test by requiring the thread factory used for these tests to not use virtual threads instead of platform threads.
>>
>> That adds some additional memory consumption, and since the test is about testing G1 reaction due to particular known memory consumption, it can fail.
>>
>> The fix is to add the appropriate `@requires` tag that has been introduced in jtreg 7.5.1 (which is current default/requirement for builds, https://bugs.openjdk.org/browse/JDK-8334759).
>>
>> Testing: verified that the test is not run if the virtual thread test thread factory is used.
>>
>> Thanks,
>> Thomas
>
> Marked as reviewed by ayang (Reviewer).
Thanks @albertnetymk @walulyai for your reviews
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25486#issuecomment-2929300941
More information about the hotspot-gc-dev
mailing list