Integrated: 8334759: gc/g1/TestMixedGCLiveThreshold.java fails on Windows with JTREG_TEST_THREAD_FACTORY=Virtual due to extra memory allocation
Thomas Schatzl
tschatzl at openjdk.org
Mon Jun 2 08:02:02 UTC 2025
On Wed, 28 May 2025 09:25:17 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this change that "fixes" the `TestMixedGCLiveThreshold.java` test by requiring the thread factory used for these tests to not use virtual threads instead of platform threads.
>
> That adds some additional memory consumption, and since the test is about testing G1 reaction due to particular known memory consumption, it can fail.
>
> The fix is to add the appropriate `@requires` tag that has been introduced in jtreg 7.5.1 (which is current default/requirement for builds, https://bugs.openjdk.org/browse/JDK-8334759).
>
> Testing: verified that the test is not run if the virtual thread test thread factory is used.
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: 3f59bfd2
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3f59bfd2e1b35e10fe736e2fa6886cff74ecd35d
Stats: 8 lines in 2 files changed: 3 ins; 5 del; 0 mod
8334759: gc/g1/TestMixedGCLiveThreshold.java fails on Windows with JTREG_TEST_THREAD_FACTORY=Virtual due to extra memory allocation
Reviewed-by: ayang, iwalulya
-------------
PR: https://git.openjdk.org/jdk/pull/25486
More information about the hotspot-gc-dev
mailing list