RFR: 8358313: G1: Refactor G1CollectedHeap::is_maximal_no_gc

Joel Sikström jsikstro at openjdk.org
Mon Jun 2 09:45:50 UTC 2025


On Mon, 2 Jun 2025 09:33:57 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple changing of a method name and return-type to be more consistent with the surrounding code.
> 
> Test: tier1

src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 1034:

> 1032: 
> 1033:   if (expanded_by == 0) {
> 1034:     assert(num_inactive_regions() == 0, "Should be no regions left, available: %u", _hrm.num_inactive_regions());

Maybe?

Suggestion:

    assert(num_inactive_regions() == 0, "Should be no regions left, available: %u", num_inactive_regions());

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25579#discussion_r2120604646


More information about the hotspot-gc-dev mailing list