RFR: 8341778: Some javac tests ignore the result of JavacTask::call

[Vicente Romero]

On Thu, 5 Jun 2025 08:43:04 GMT, Johannes Döbler <duke at openjdk.org> wrote:

>> test/langtools/tools/javac/patterns/SOEDeeplyNestedBlocksTest.java line 37:
>> 
>>> 35: public class SOEDeeplyNestedBlocksTest {
>>> 36: 
>>> 37:     static final int NESTING_DEPTH = 500;
>> 
>> Same question here.
>
> With a NESTING_DEPTH of 1000 javac will run into a StackOverflowError, but it still completes and task.call() returns false. Using 500 javac can compile without error. Not sure what this test wants to prove. If it wants to show that javac can complete without throwing an SOE then it should keep depth 1000 and test that task.call() returns false.

yes this one was failing quietly, this test is stressing a code that was modified due to pattern matching. It is testing that javac can deal with deeply nested code without throwing SOE. 1000 depth was too much and the test was quietly failing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25645#discussion_r2128881821