RFR: 8359110: Log accumulated GC and process CPU time upon VM exit [v5]

Jonas Norlinder duke at openjdk.org
Mon Jun 16 09:03:32 UTC 2025


On Mon, 16 Jun 2025 06:37:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jonas Norlinder has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add CPU time tracking for string deduplication to log_gc_vtime
>
> src/hotspot/share/gc/shared/vtimeScope.inline.hpp line 35:
> 
>> 33:     : _start(0), _enabled(os::is_thread_cpu_time_supported()),
>> 34:       _gcLogging(operation_is_gc && (log_is_enabled(Info, gc) || log_is_enabled(Info, gc, cpu))),
>> 35:       _thread((Thread*)thread) {
> 
> Cast should not be necessary

Not casting requires adding `#include "runtime/vmThread.hpp"`. Will add that since that seems to be preferred.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2149417216


More information about the hotspot-gc-dev mailing list