RFR: 8360024: Reorganize GC VM operations and implement is_gc_operation [v2]

[Jonas Norlinder]

On Mon, 23 Jun 2025 07:56:57 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Jonas Norlinder has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Re-align arguments
>
> src/hotspot/share/gc/shared/gcVMOperations.hpp line 47:
> 
>> 45: //          VM_CollectForAllocation
>> 46: //            VM_SerialCollectForAllocation
>> 47: //            VM_ParallelCollectForAllocation
> 
> Suggestion:
> 
> //          e.g. VM_SerialGCCollector
> //          VM_CollectForAllocation
> //            e.g. VM_SerialCollectForAllocation
> 
> 
> This is not a real suggestion, but this hierarchy isn't complete, and I am not sure we should make it complete. Since we already skip Z/G1/Shenandoah operations here, I do not really see that Serial/Parallel specific operations should be here either.
> 
> Or maybe explicitly state Serial/Parallel vm ops as examples here as suggested above, but that does not look right either.
> 
> However this is kind of unrelated to this PR :)

Given that the comment was wrong to begin with, i.e. `VM_PopulateDynamicDumpSharedSpace` was under  `VM_GC_Operation` but actually it inherited from `VM_GC_Sync_Operation`, we migh consider removing the comment? But as you say, this discussion belong in another PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25896#discussion_r2161248592