RFR: JDK-8349077 : Rename GenerationCounters::update_all [v8]

Albert Mingkun Yang ayang at openjdk.org
Wed Jun 25 08:28:31 UTC 2025


On Tue, 24 Jun 2025 13:32:04 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077)
>> 
>> we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity).
>> 
>> 
>> 
>> Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method.
>
> Suchismith Roy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into update_memory_state
>  -  Zgneeration class redundant
>  - g1Monitoring
>  - update zgenerationcounter
>  - psOldGen
>  - update capacity only for Generation counter
>  - Revert "update_capacity exists"
>    
>    This reverts commit cf2d66d598d90f1343d1ad7a4f30607c3374a0f8.
>  - Merge branch 'openjdk:master' into update_memory_state
>  - update_capacity exists

src/hotspot/share/gc/z/zServiceability.cpp line 57:

> 55: private:
> 56:   GenerationCounters _generation_young_counters;
> 57:   GenerationCounters _generation_old_counters;

These two field names are not aligned any more.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25833#discussion_r2166115917


More information about the hotspot-gc-dev mailing list