RFR: JDK-8349077 : Rename GenerationCounters::update_all [v7]

Stefan Karlsson stefank at openjdk.org
Wed Jun 25 08:59:32 UTC 2025


On Tue, 24 Jun 2025 08:48:45 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077)
>> 
>> we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity).
>> 
>> 
>> 
>> Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method.
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
> 
>    Zgneeration class redundant

src/hotspot/share/gc/z/zServiceability.cpp line 57:

> 55: private:
> 56:   GenerationCounters _generation_young_counters;
> 57:   GenerationCounters _generation_old_counters;

Suggestion:

  GenerationCounters  _generation_young_counters;
  GenerationCounters  _generation_old_counters;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25833#discussion_r2163420271


More information about the hotspot-gc-dev mailing list