RFR: JDK-8349077 : Rename GenerationCounters::update_all [v10]

Stefan Karlsson stefank at openjdk.org
Wed Jun 25 13:08:33 UTC 2025


On Wed, 25 Jun 2025 12:35:47 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> JBS Issue : [JDK-8349077](https://bugs.openjdk.org/browse/JDK-8349077)
>> 
>> we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity).
>> 
>> 
>> 
>> Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method.
>
> Suchismith Roy has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Update shenandoahMonitoringSupport.cpp
>  - Update epsilonMonitoringSupport.cpp
>  - Update epsilonMonitoringSupport.cpp

Marked as reviewed by stefank (Reviewer).

Some extra info about copyrights:
https://openjdk.org/guide/#copyright-headers

-------------

PR Review: https://git.openjdk.org/jdk/pull/25833#pullrequestreview-2958085034
PR Comment: https://git.openjdk.org/jdk/pull/25833#issuecomment-3004701364


More information about the hotspot-gc-dev mailing list