RFR: 8358586: ZGC: Combine ZAllocator and ZObjectAllocator [v9]

Joel Sikström jsikstro at openjdk.org
Wed Jun 25 14:05:48 UTC 2025


On Wed, 25 Jun 2025 13:44:12 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Joel Sikström has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Copyright year
>>  - Move definition of ZDeferredConstructed to inline header
>
> src/hotspot/share/gc/z/zDeferredConstructed.inline.hpp line 79:
> 
>> 77: 
>> 78: template <typename T>
>> 79: template<typename... Ts>
> 
> Suggestion:
> 
> template <typename... Ts>
> 
> 
> We added a few of these without a space in 7e69b98e0548803b85b04b518929c073f8ffaf8c as well. Will have to clean them up at some point :)

Ah, good catch. I see that we have the following to fix at some point:

src/hotspot/share/gc/z/zPhysicalMemoryManager.cpp:162:1:template<>            
src/hotspot/share/gc/z/zValue.hpp:117:1:template<typename S, typename T>      
src/hotspot/share/gc/z/zArray.hpp:35:1:template<typename T> class ZArray;     
src/hotspot/share/gc/z/zPhysicalMemoryManager.cpp:171:1:template<typename... 
src/hotspot/share/gc/z/zPhysicalMemoryManager.cpp:156:3:  template<typename...
src/hotspot/share/gc/z/zPhysicalMemoryManager.cpp:164:3:  template<typename...
 ```

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25693#discussion_r2166802891


More information about the hotspot-gc-dev mailing list