RFR: 8360522: G1: Flag constraint functions for G1SATBBufferSize and G1UpdateBufferSize are skipped during argument validation
SendaoYan
syan at openjdk.org
Thu Jun 26 01:23:29 UTC 2025
On Wed, 25 Jun 2025 12:53:03 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
> Hi,
>
> Please review this change to move constraint function execution for G1SATBBufferSize and G1UpdateBufferSize to AfterErgo. These functions rely on the UseG1GC flag to determine whether to apply checks. However, during the AtParse phase of argument handling, UseG1GC may not yet be processed, which causes the constraints to be skipped.
>
> Testing:
> `java -XX:G1SATBBufferSize=0 -version`
> `G1SATBBufferSize (0) must be in range [1, 4294967295]`
> `Error: Could not create the Java Virtual Machine.`
> `Error: A fatal exception has occurred. Program will exit.`
src/hotspot/share/gc/g1/g1_globals.hpp line 147:
> 145: product(size_t, G1SATBBufferSize, 1*K, \
> 146: "Number of entries in an SATB log buffer.") \
> 147: constraint(G1SATBBufferSizeConstraintFunc, AfterErgo) \
Should we update the copyrighy year from 2024 to 2025
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25979#discussion_r2167905971
More information about the hotspot-gc-dev
mailing list