RFR: 8274051: Remove supports_vtime()/elapsedVTime() [v2]

Thomas Schatzl tschatzl at openjdk.org
Fri Jun 27 09:39:34 UTC 2025


On Thu, 26 Jun 2025 19:27:57 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   * kbarrett review
>
> src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 2090:
> 
>> 2088: 
>> 2089:     void do_thread(Thread* t) {
>> 2090:       _total_cpu_time = os::thread_cpu_time(t);
> 
> Shouldn't this be `+=` rather than just `+`?

nice catch! Fixed.

> src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 2272:
> 
>> 2270:   }
>> 2271: 
>> 2272:   jlong curr_time_ns = os::current_thread_cpu_time();
> 
> pre-existing: I wonder why this is here, rather than a few lines later, near where it's used.

I do not know either, and found it confusing too. I fixed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26001#discussion_r2171406859
PR Review Comment: https://git.openjdk.org/jdk/pull/26001#discussion_r2171409629


More information about the hotspot-gc-dev mailing list