RFR: 8359110: Log accumulated GC and process CPU time upon VM exit [v10]
Thomas Schatzl
tschatzl at openjdk.org
Mon Jun 30 14:53:41 UTC 2025
On Mon, 30 Jun 2025 13:55:24 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> I've listed a couple more nits.
>
> Given that JDK-8274051 has now been integrated should the os::elapsedVTime be removed from this patch?
>
> I know that we talked about the vtime name earlier. Should we still use the `vtime` name now that we have removed elapsedVTime?
I concur with @stefank: we just removed `vtime` in other gc code, simply using `cpu_time`.
`_vmthread_cpu_time` seems to be a lot more descriptive than `_vm_vtime`. At least add `thread` - the name of that thread is `VMThread` after all (as opposed to the whole VM what the current name implies to me).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25779#issuecomment-3019468123
More information about the hotspot-gc-dev
mailing list