RFR: 8358529: GenShen: Heuristics do not respond to changes in SoftMaxHeapSize [v2]

[William Kemper]

On Mon, 23 Jun 2025 23:04:11 GMT, Rui Li <duke at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahGeneration.hpp line 129:
>> 
>>> 127:   virtual ShenandoahHeuristics* initialize_heuristics(ShenandoahMode* gc_mode);
>>> 128: 
>>> 129:   size_t soft_max_capacity() const override;
>> 
>> Can we take out the `_soft_max_capacity` member from `ShenandoahGeneration` now?
>
> Yes. Good catch. Removed

I think we can cut deeper here. If `ShenandoahHeap` is now the sole source of truth for soft max heap size, can we remove the `soft_max_capacity` getter method from `ShenandoahGeneration` (and `ShenandoahSpaceInfo`)? All the callers can just get this value directly from `ShenandoahHeap` now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25943#discussion_r2175728375