RFR: 8351077: Shenandoah: Update comments in ShenandoahConcurrentGC::op_reset_after_collect [v2]

William Kemper wkemper at openjdk.org
Tue Mar 4 01:08:54 UTC 2025


On Tue, 4 Mar 2025 00:58:27 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> This is a trivial PR to update the code comments in ShenandoahConcurrentGC::op_reset_after_collect.
>> 
>> After doing more test and analysis, we have a better understanding why reset bitmap of young gen after concurrent cycle may cause crash if there is pending old GC cycle to execute: When there is soft reference in old gen, but the referent is in young, reseting bitmap of young will cause wrong state of the soft reference, which may lead to expected cashes.
>
> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update code comments as suggested in PR

Marked as reviewed by wkemper (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23872#pullrequestreview-2655679787


More information about the hotspot-gc-dev mailing list