RFR: 8351091: Shenandoah: global marking context completeness is not accurately maintained [v4]

[William Kemper]

On Thu, 6 Mar 2025 18:34:43 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> With the JEP 404: Generational Shenandoah implementation, there are generation specific marking completeness flags introduced, and the global marking context completeness flag is not updated at all after initialization, hence the global marking context completeness is not accurate anymore. This may cause expected behavior: [ShenandoahHeap::complete_marking_context()](https://github.com/openjdk/jdk/pull/23886/files#diff-d5ddf298c36b1c91bf33f9bff7bedcc063074edd68c298817f1fdf39d2ed970fL642) should throw assert error if the global marking context completeness flag is false, but now it always return the marking context even it marking is not complete, this may hide bugs where we expect the global/generational marking to be completed.
>> 
>> This change PR fix the bug in global marking context completeness flag, and update all the places using `ShenandoahHeap::complete_marking_context()` to use proper API.
>> 
>> ### Test
>> - [x] hotspot_gc_shenandoah
>> - [x] Tier 1
>> - [x]  Tier 2
>
> Xiaolong Peng has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Remove ShenandoahHeap::complete_marking_context(ShenandoahHeapRegion* region)
>  - Revert "complete_marking_context should guarantee mark is complete"
>    
>    This reverts commit 2004973965ea0e617cf9e5fc45be24f0e06e90a1.
>  - complete_marking_context should guarantee mark is complete

Thanks for cleaning this up.

-------------

Marked as reviewed by wkemper (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23886#pullrequestreview-2665341497