RFR: 8351091: Shenandoah: global marking context completeness is not accurately maintained [v4]
Xiaolong Peng
xpeng at openjdk.org
Thu Mar 6 23:12:53 UTC 2025
On Thu, 6 Mar 2025 22:27:59 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Technically there is only one global marking context for Shenandoah, even in generational mode, passing the region to marking_context doesn't make any difference.
>>
>> But in the method `complete_marking_context(r)`, it checks if the affiliated generation has complete marking, it is a more convenient version of `complete_marking_context(affiliation)`.
>
> OK, yes, that makes sense. Why not then use both `ShenandoahHeap::[complete_]marking_context()` as synonyms for `ShehandoahHeap::active_generation()->[complete_]marking_context()`. See other related comments in this review round.
I feel using `henandoahHeap::complete_marking_context()` as synonyms for `ShehandoahHeap::active_generation()->[complete_]marking_context()` may cause more confusion, just read from the name it seems that it indicates the marking is complete for the whole heap, not just the active generation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23886#discussion_r1984170738
More information about the hotspot-gc-dev
mailing list