RFR: 8351091: Shenandoah: global marking context completeness is not accurately maintained [v4]

[Xiaolong Peng]

On Thu, 6 Mar 2025 23:34:21 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahGenerationalEvacuationTask.cpp line 172:
>> 
>>> 170: // contained herein.
>>> 171: void ShenandoahGenerationalEvacuationTask::promote_in_place(ShenandoahHeapRegion* region) {
>>> 172:   ShenandoahMarkingContext* const marking_context = _heap->young_generation()->complete_marking_context();
>> 
>> For clarity, you might assert the following before line 172:
>> 
>>     assert(gc_generation() == _heap->young_generation(), "Sanity check");
>> 
>> 
>> Even though it might seem somewhat tautological.
>
> Thanks, I'll add it.

Question: Does Shenandoah promote region in global cycles? the gc_generation might be global if so.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23886#discussion_r1984203547