RFR: 8351444: Shenandoah: Class Unloading may encounter recycled oops [v2]

William Kemper wkemper at openjdk.org
Mon Mar 10 21:12:57 UTC 2025


On Mon, 10 Mar 2025 19:42:30 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Consider trash regions to be in the heap during concurrent weak roots
>>  - Better comment for LRB when accessing unreachable oops
>
> src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp line 127:
> 
>> 125:   // Note that this may also interfere with the DeadCounterClosure when visiting weak oop storage,
>> 126:   // but it does not seem to be a problem in practice because the dead count callbacks do not care
>> 127:   // about the precise number of dead objects (only that there are dead objects).
> 
> The last 3 lines feel too specific, really :) I think that paragraph should be in the related bug report.

Okay.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23951#discussion_r1988028969


More information about the hotspot-gc-dev mailing list