RFR: 8351500: G1: NUMA migrations cause crashes in region allocation [v2]

[Thomas Stuefe]

On Thu, 13 Mar 2025 08:50:40 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   node_index parameter should precede output parameters
>
> I agree with keeping this patch small and then at some point doing a larger refactor in this area. I also agree that we want the out-parameter last, but when reading the parameters now you get sizing parameters split by the node index parameter, i.e: 
> 
> HeapWord* result = _allocator->attempt_allocation(min_word_size, desired_word_size, node_index, actual_word_size);
> 
> 
> I would prefer the node index first here, like:
> 
> HeapWord* result = _allocator->attempt_allocation(node_index, min_word_size, desired_word_size, actual_word_size);
> 
> For this one: 
> 
>   HeapWord* par_allocate_during_gc(G1HeapRegionAttr dest,
>                                    size_t min_word_size,
>                                    size_t desired_word_size,
>                                    uint node_index,
>                                    size_t* actual_word_size);
> 
> 
> I would prefer to put the node_index after dest but before the sizes.
> 
> What do you think?

@kstefanj I rewrote the patch to put node_index at the front.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23984#issuecomment-2720854399