RFR: 8351405: G1: Collection set early pruning causes suboptimal region selection [v2]
Thomas Schatzl
tschatzl at openjdk.org
Wed Mar 19 09:55:09 UTC 2025
On Wed, 19 Mar 2025 08:32:49 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Hi all,
>>
>> Please review this change which aims to reduce spikes in mixed GCs, especially the last mixed-gc in a mixed cycle. Currently, G1 sorts regions identified for collection by reclaimable bytes, then prunes the list removing regions that with the lowest amount of reclaimable bytes. The pruned list is then split into collection groups which are later sorted on gc-efficiency.
>>
>> In the cachestress benchmark, we run into a case where some regions contain onlya few live objects but having many incoming references from other regions. These regions very expensive collect (low gc-efficiency).
>>
>> This patch improves the pruning process by tracking incoming references to regions during marking. Instead of pruning based on reclaimable bytes alone, we estimate GC efficiency beforehand and prune regions with the worst GC efficiency.
>>
>> This reduces the spikes in gc pause time as shown for cachestress benchmark in the image below.
>>
>> 
>>
>>
>> Testing: Tier 1-3.
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>
> Thomas Review
Marked as reviewed by tschatzl (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24076#pullrequestreview-2697733082
More information about the hotspot-gc-dev
mailing list