RFR: 8352185: Shenandoah: Invalid logic for remembered set verification [v13]
Xiaolong Peng
xpeng at openjdk.org
Fri Mar 21 00:25:14 UTC 2025
On Thu, 20 Mar 2025 23:21:37 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:
>> I'd leave a comment to this effect (along the lines of Kelvin's last comment) here. Did we measure the impact of this change on performance? In particular it would seem that the number of dirty old cards might now reduce after a global gc compared to before this change.
>>
>> Ideally, this would be a change that would go in on its own. (There is no impact on correctness, since in the absence of this change, the dirty card set is an over-approximation.)
>
> It is a bit hard to measure the impact on performance I think, but given the rem-set is more accurate, there shouldn't be any performance regression.
I'll add comment here as you are suggesting.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24092#discussion_r2006650222
More information about the hotspot-gc-dev
mailing list