RFR: 8352588: GenShen: Enabling JFR asserts when getting GCId [v2]
Xiaolong Peng
xpeng at openjdk.org
Fri Mar 21 23:26:46 UTC 2025
On Fri, 21 Mar 2025 23:10:48 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahController.cpp line 50:
>>
>>> 48: }
>>> 49:
>>> 50: size_t ShenandoahController::get_gc_id() {
>>
>> Do we need to keep this method? Can't everything just use `get_gc_count` now?
>
> We don't have to keep it, it needs a bit more changes to touch up. I think it better to remove it to avoid the confusion with the gc_id() method,
I have removed method ShenandoahController::get_gc_id() in the update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24166#discussion_r2008466559
More information about the hotspot-gc-dev
mailing list