RFR: 8352762: Use EXACTFMT instead of expanded version where applicable

Joel Sikström jsikstro at openjdk.org
Thu Mar 27 15:52:19 UTC 2025


On Thu, 27 Mar 2025 04:52:17 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) introduced the EXACTFMT macro, which is a shorthand for printing exact values using methods defined in globalDefinitions.hpp. There are currently 20 places in HotSpot which uses the expanded version of the macro, along with the "trace_page_size_params" macro that is defined and used in os.cpp.
>> 
>> I have replaced places that use the expanded macro(s) with EXACTFMT + EXACTFMTARGS, and also removed trace_page_size_params from os.cpp, which was essentially a redefnition of EXACTFMTARGS.
>> 
>> Testing: GHA, tiers 1-4
>
> Paging @tstuefe ! Thomas added EXACTFMT in [JDK-8310233](https://github.com/openjdk/jdk/pull/14739/files#top) and did not use it for some of the places where you are now using it. Despite being a reviewer of Thomas's change, I'm not at all sure when EXACTFMT should be used. But this looks good.

Thank you for the reviews! @dholmes-ora @tstuefe

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24228#issuecomment-2758536909


More information about the hotspot-gc-dev mailing list