RFR: 8356083: ZGC: Duplicate ZTestEntry symbols in gtests
Axel Boldt-Christmas
aboldtch at openjdk.org
Mon May 5 11:21:46 UTC 2025
On Mon, 5 May 2025 09:43:50 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:
> Hello,
>
> There are duplicate definitions of ZTestEntry (one in test_zList.cpp and one in test_zIntrusiveRBTree.cpp). This results in a crash when running the ZList tests on slowdebug, where the ZTestEntry symbol from test_zIntrusiveRBTre.cpp is used over the one in test_zList.cpp.
>
> To remove the collision, I've renamed ZTestEntry in test_zIntrusiveRBTre.cpp to ZRBTestEntry, and ZTestEntryCompare to ZRBTestEntryCompare to reflect this change.
>
> I've verified that the gtests run and pass by running them locally on release, fastdebug and slowdebug.
lgtm.
-------------
Marked as reviewed by aboldtch (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25029#pullrequestreview-2814492407
More information about the hotspot-gc-dev
mailing list