RFR: 8345067: C2: enable implicit null checks for ZGC reads

Emanuel Peter epeter at openjdk.org
Thu May 8 11:29:02 UTC 2025


On Thu, 8 May 2025 10:29:17 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/block.hpp line 468:
>> 
>>> 466: 
>>> 467:   // If necessary, hoist orphan node n into the end of block b.
>>> 468:   void maybe_hoist_into(Node* n, Block* b);
>> 
>> Hmm. It is "if necessary" or "if possible"?
>> I wonder if we could come up with a name that is a little longer and expresses this condition?
>
> Ah no, I'm starting to understand that it is rather a `if necessary`...

See further comments at `maybe_hoist_into` and my suggestions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25066#discussion_r2079512983


More information about the hotspot-gc-dev mailing list