RFR: 8356667: GenShen: Eliminate races with ShenandoahFreeSet::available() [v2]
Kelvin Nilsen
kdnilsen at openjdk.org
Tue May 13 17:55:10 UTC 2025
On Mon, 12 May 2025 23:28:44 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Respond to reviewer comments
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 234:
>
>> 232: }
>> 233:
>> 234: // Acquire heap lock and return available_in, assuming heap lock is not acquired by the caller.
>
> Sorry - can we change this comment too? This method does _not_ acquire the lock in release builds. Comment could mention that it acquires the lock only for the correctness of the assertion?
Very good point. I've made this change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25165#discussion_r2087358566
More information about the hotspot-gc-dev
mailing list