RFR: 8357218: G1: Remove loop in G1CollectedHeap::try_collect_fullgc [v4]

[Kim Barrett]

On Mon, 19 May 2025 14:07:37 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Simple removing unnecessary loop in "caller" of `VM_G1CollectFull`, because an explicit full-gc always run-to-completion.
>> 
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - review
>  - Revert "review"
>    
>    This reverts commit 666cc5a1cbc72453a09fdf4e9319bf140365859e.

Changes requested by kbarrett (Reviewer).

src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 1885:

> 1883:                         cause);
> 1884:     VMThread::execute(&op);
> 1885:     return op.prologue_succeeded();

They might now be the same value, but `gc_succeeded()` seems like a better semantic fit here.
Looking around a little, it's not obvious why `prologue_succeeded()` is ever the right name for a
client-accessible test for what seems like gc-completion.  But that's a separate issue.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25296#pullrequestreview-2850997116
PR Review Comment: https://git.openjdk.org/jdk/pull/25296#discussion_r2095857029