RFR: 8357218: G1: Remove loop in G1CollectedHeap::try_collect_fullgc [v4]

[Thomas Schatzl]

On Tue, 20 May 2025 07:17:16 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> I think the question that clients care about is whether the gc succeeded.
>> Whether the prologue succeeded or not might be used as part of the
>> implementation of that. That is, I think gc_succeeded ought to be part of the
>> public API for GC operations, and prologue_succeeded shouldn't be, with some
>> gc_succeeded operations being implemented as just a call to
>> prologue_succeeded.
>> 
>> That probably shouldn't be part of this change though. Instead, I'd prefer
>> this change maintain the status quo in this area. Or do what @tschatzl
>> suggested, which I saw as I was about to post this.
>
> Added back the API.

> I think the question that clients care about is whether the gc succeeded.
Whether the prologue succeeded or not might be used as part of the
implementation of that. That is, I think gc_succeeded ought to be part of the
public API for GC operations, and prologue_succeeded shouldn't be, with some
gc_succeeded operations being implemented as just a call to
prologue_succeeded.

Agree. Filed JDK-8357307.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25296#discussion_r2097178221