RFR: 8357306: G1: Remove _gc_succeeded from VM_G1CollectForAllocation because it is always true [v2]

Albert Mingkun Yang ayang at openjdk.org
Thu May 22 07:01:59 UTC 2025


On Wed, 21 May 2025 10:08:29 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this refactoring of G1 VM GC operations to remove the _gc_succeeded members because they are not necessary any more - GC operations themselves (i.e. the doit() part) always succeed.
>> 
>> Testing: tier1-3, gha
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into 8357306-remove-gc-succeeded-in-g1-vm-operations
>  - * remove comment
>  - * fix try-concurrent-...
>  - * some minor refactoring
>  - 8357306
>    
>    Hi all,
>    
>      please review this refactoring of G1 VM GC operations to remove the _gc_succeeded members because they are not necessary any more - GC operations themselves (i.e. the doit() part) always succeed.
>    
>    Testing: tier1-3, gha
>    
>    Thanks,
>      Thomas

Marked as reviewed by ayang (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25320#pullrequestreview-2860021285


More information about the hotspot-gc-dev mailing list