RFR: 8357449: ZGC: Multiple medium page sizes [v3]

Axel Boldt-Christmas aboldtch at openjdk.org
Thu May 22 10:29:50 UTC 2025


On Thu, 22 May 2025 09:16:08 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Retype ZPageSizeSmallShift to int
>>  - Rename ZPageSizeMediumShift -> ZPageSizeMediumMaxShift
>>  - Update is_disabled comment
>
> src/hotspot/share/gc/z/zGlobals.hpp line 46:
> 
>> 44: // Page size shifts
>> 45: const size_t      ZPageSizeSmallShift           = ZGranuleSizeShift;
>> 46: extern int        ZPageSizeMediumShift;
> 
> Changing to int seems good, but this leaves an inconsistency with `ZPageSizeSmallShift`. I'd prefer if the type of that constant was also changed in this PR.

Yeah, was unsure how far to push this. Eventually all our shift variables should probably be typed as int. But will change the page size shifts at least then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25381#discussion_r2102216608


More information about the hotspot-gc-dev mailing list