Integrated: 8357563: Shenandoah headers leak un-prefixed defines

[Stefan Karlsson]

On Thu, 22 May 2025 12:36:07 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> We hit a compilation error in ZGC when we defined a constant NumPartitions. This happened because there is a define name NumPartitions inside shenandoahFreeSet.hpp. I propose that this (and its friends) are hid inside the ShenandoahRegionPartitions class, which is the only user of these defines. An alternative would be to prefix the define with something that is unlikely to clash with other parts of HotSpot.
> 
> This PR is my suggestion for a change to solve this so this name conflict. Does this seem like an acceptable solution, or do you want something else? Thanks!

This pull request has now been integrated.

Changeset: 68ee06f0
Author:    Stefan Karlsson <stefank at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/68ee06f0c9ec420cb1a60e0b361971372b18b82b
Stats:     12 lines in 1 file changed: 6 ins; 6 del; 0 mod

8357563: Shenandoah headers leak un-prefixed defines

Reviewed-by: shade, kbarrett

-------------

PR: https://git.openjdk.org/jdk/pull/25392