RFR: 8357621: G1: Clean up G1BiasedArray

Stefan Johansson sjohanss at openjdk.org
Fri May 23 10:21:55 UTC 2025


On Fri, 23 May 2025 08:07:04 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this minor touch-up of the G1BiasedArray classes, removing some unused methods and improving method visibility a bit.
> 
> Testing: gha
> 
> Thanks,
>   Thomas

Looks good.

Changes requested by sjohanss (Reviewer).

Or are there build issues.

src/hotspot/share/gc/g1/g1BiasedArray.hpp line 171:

> 169: protected:
> 170:   // Returns the address of the element the given address maps to
> 171:   T* address_mapped_to(HeapWord* address) {

Seems to be used by testing.

-------------

Marked as reviewed by sjohanss (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25406#pullrequestreview-2863934534
PR Review: https://git.openjdk.org/jdk/pull/25406#pullrequestreview-2863945561
PR Comment: https://git.openjdk.org/jdk/pull/25406#issuecomment-2903965932
PR Review Comment: https://git.openjdk.org/jdk/pull/25406#discussion_r2104289012


More information about the hotspot-gc-dev mailing list