RFR: 8357621: G1: Clean up G1BiasedArray [v2]

Thomas Schatzl tschatzl at openjdk.org
Fri May 23 12:36:51 UTC 2025


On Fri, 23 May 2025 11:51:15 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Re-add address_mapped_to, used by testing
>
> src/hotspot/share/gc/g1/g1BiasedArray.hpp line 106:
> 
>> 104: class G1BiasedMappedArray : public G1BiasedMappedArrayBase {
>> 105: 
>> 106:   T* base() const { return (T*)G1BiasedMappedArrayBase::_base; }
> 
> Looks like `base() `needs to be public for testing as well :(

Sorry for all these issues, I just found out that I did not have gtests configured for my build. Should be fixed now.

I moved the test helper methods into the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25406#discussion_r2104496443


More information about the hotspot-gc-dev mailing list