RFR: 8354428: [ubsan] g1BiasedArray.hpp: pointer overflow in address calculation [v3]

Kim Barrett kbarrett at openjdk.org
Wed May 28 01:11:54 UTC 2025


On Tue, 27 May 2025 09:25:38 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this fix for an ubsan error related to pointer under- or overflows when using the biased array helper.
>> 
>> The fix is, instead of using direct address calculations that can cause these errors, use `uintptr_t` where the overflow behavior is defined in C++. Only convert to pointer at the actual access.
>> 
>> Testing: gha, tier1
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   * kbarrett review

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25447#pullrequestreview-2873210429


More information about the hotspot-gc-dev mailing list