RFR: 8357944: Remove unused CollectedHeap::is_maximal_no_gc
Joel Sikström
jsikstro at openjdk.org
Fri May 30 11:48:50 UTC 2025
On Wed, 28 May 2025 07:17:14 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Removing effectively dead code/API for all GCs except G1.
Looks good. This code is quite old, but I wonder if it's also appropriate to rename `is_maximal_no_gc()` to something more descriptive, maybe `is_expandable()` and reverse the check, which I think looks better at the callers of `is_maximal_no_gc()`. Not sure if that should be done separately or not though, and I don't have strong opinions on G1 code.
-------------
Marked as reviewed by jsikstro (Committer).
PR Review: https://git.openjdk.org/jdk/pull/25482#pullrequestreview-2881111569
More information about the hotspot-gc-dev
mailing list