RFR: 8358735: GenShen: block_start() may be incorrect after class unloading [v2]

Kelvin Nilsen kdnilsen at openjdk.org
Mon Nov 10 23:45:41 UTC 2025


On Fri, 3 Oct 2025 20:18:46 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix idiosyncratic formatting
>
> src/hotspot/share/gc/shenandoah/shenandoahMarkBitMap.hpp line 131:
> 
>> 129:   inline idx_t get_next_one_offset(idx_t l_index, idx_t r_index) const;
>> 130: 
>> 131:   // Search for last one in the range [l_index, r_index).  Return r_index if not found.
> 
> Symmetry arguments wrt spec for `get_next_one_offset` may have preferred range `(l_index, r_index]`, returning `l_index` if none found. May be its (transitive) usage prefers this shape? (See similar comment at line 180.)

See comment above regarding asymmetry.   It is by design, due to shape of the data.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27353#discussion_r2512329320


More information about the hotspot-gc-dev mailing list