RFR: 8371381: [Shenandoah] Setting ergo flags should use FLAG_SET_ERGO [v2]

William Kemper wkemper at openjdk.org
Wed Nov 12 01:01:02 UTC 2025


On Tue, 11 Nov 2025 23:52:24 GMT, Rui Li <duke at openjdk.org> wrote:

>> OK, I'll keep the range as it is `(1,100)`, but instead of setting the default with ergo at here: https://github.com/openjdk/jdk/blob/c6a8027b94bbcbde5f7dcabd0bff48b93bbb5a7f/src/hotspot/share/gc/shenandoah/mode/shenandoahPassiveMode.cpp#L40-L42 I'll just use `FLAG_SET_DEFAULT` to bypass the check? We wouldn't have the data source origin in passive mode which is only meant to be diagnostic, but that's better than causing problems in the regular mode.
>
> Ah, missed your general comment above. I think we're talking about the same solution. I'll update the passive mode to use `FLAG_SET_DEFAULT`.

Yeah, that's what I was suggesting. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28242#discussion_r2516301969


More information about the hotspot-gc-dev mailing list