RFR: 8371667: Shenandoah: Re-design alloc request type enum for better efficiency and cleaner code [v10]

Aleksey Shipilev shade at openjdk.org
Mon Nov 17 09:55:11 UTC 2025


On Thu, 13 Nov 2025 00:23:01 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   _alloc_plab is also lab alloc
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 3272:
> 
>> 3270:     switch (req.type()) {
>> 3271:       case ShenandoahAllocRequest::_alloc_shared:
>> 3272:       case ShenandoahAllocRequest::_alloc_shared_gc:
> 
> humongous objects never move, not possible to be _alloc_shared_gc here?

Yes, I am not sure why we have the case for `_alloc_shared_gc` here. But I would leave it for extra safety in this "optimization/cleanup" change. We can yank this case later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28247#discussion_r2533422472


More information about the hotspot-gc-dev mailing list